feat(remote-feature-flag-controller): segment threshold flags by metaMetricsFlags with canonical ID default - #9325
Merged
Conversation
…y and support canonical id segmentation Threshold flags now expose selected values directly, track group names in featureFlagThresholdGroups, and can use getCanonicalId when idType is canonical. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
asalsys
changed the title
…nd changelog links Default threshold segmentation to canonical ID, link changelog entries to PR #9325, add wallet changelog entry, and fix ESLint violations. Co-authored-by: Cursor <cursoragent@cursor.com>
asalsys
enabled auto-merge
July 1, 2026 03:11
1 task
asalsys
changed the title
NicolasMassart
previously approved these changes
Jul 7, 2026
NicolasMassart
self-requested a review
July 7, 2026 16:14
NicolasMassart
previously approved these changes
Jul 7, 2026
davidmurdoch
requested changes
Aug 19, 2026
davidmurdoch
left a comment
davidmurdoch
left a comment
Contributor
There was a problem hiding this comment.
I don't really understand why this change is needed, but have left a comment about the API anyway.
…hub.com:MetaMask/core into feat/remote-feature-flag-threshold-groups-clean
…ure-flag-threshold-groups-clean
davidmurdoch
approved these changes
Aug 19, 2026
davidmurdoch
left a comment
davidmurdoch
left a comment
Contributor
There was a problem hiding this comment.
I don't understand the reason for this. but from a code and api standpoint, it looks good.
weitingsun
approved these changes
Aug 19, 2026
mcmire
approved these changes
Aug 20, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 09b141f. Configure here.
mcmire
disabled auto-merge
August 20, 2026 15:47
runway-github Bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 9, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/wallet` to `^12.0.0` ```markdown ## [12.0.0] ### Added - Add optional `instanceOptions.remoteFeatureFlagController.getCanonicalProfileId` constructor option to `RemoteFeatureFlagController` for threshold flag segmentation ([#9325](MetaMask/core#9325)) - Add optional `instanceOptions.remoteFeatureFlagController.metaMetricsFlags` constructor option to `RemoteFeatureFlagController` to segment flags by MetaMetrics ID ([#9325](MetaMask/core#9325)) - **BREAKING:** Wire `ConfigRegistryApiService` and `ConfigRegistryController` into the default wallet initialization ([#9928](MetaMask/core#9928)) - Adds a required `configRegistryApiService` slot to `instanceOptions` with a required `env` (`ConfigRegistryApiEnv`) and optional `fetch` and `policyOptions`. `fetch` defaults to `globalThis.fetch` via `ConfigRegistryApiService`. - Adds an optional `configRegistryController` slot to `instanceOptions` for optional `pollingInterval` and `fallbackConfig`. - `ConfigRegistryController` delegates `KeyringController:getState`, `RemoteFeatureFlagController:getState`, and `ConfigRegistryApiService:fetchConfig`, and subscribes to `KeyringController:unlock`, `KeyringController:lock`, and `RemoteFeatureFlagController:stateChange`. - Consumers that pass their own root messenger and already wire `ConfigRegistryApiService` / `ConfigRegistryController` must remove their own before upgrading, or the duplicate registration will collide. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/WPN-1879 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches remote feature flag segmentation, persisted state migration, and moves config registry initialization into wallet—behavior changes at sign-in and upgrade paths warrant careful QA. > > **Overview** > Upgrades **`@metamask/wallet`** to **^12.0.3** with **`@metamask/config-registry-controller` ^3** and **`@metamask/remote-feature-flag-controller` ^6.1.1**, and removes the extension’s duplicate **Config Registry** messenger-client init so **`ConfigRegistryController`** / **`ConfigRegistryApiService`** are owned by the wallet (including new **`getConfigRegistryApiServiceInstanceOptions`** with PRD vs UAT env from build type). > > **Remote feature flags** are updated for RFFC 6: **`getCanonicalProfileId`** (from **`AuthenticationController`**, MetaMetrics fallback), safer early-init ID resolution, and **`setupRemoteFeatureFlagToggle`** now listens for auth state changes and **force-refreshes** flags when the canonical profile id appears or changes. Migration **224.1** strips persisted **`rawRemoteFeatureFlags`** so old redacted cache is not reused. > > E2E fixtures/mocks and LavaMoat policies are adjusted for threshold-flag shape and wallet-owned packages. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 967b8ce. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
runway-github Bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 9, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/wallet` to `^12.0.0` ```markdown ## [12.0.0] ### Added - Add optional `instanceOptions.remoteFeatureFlagController.getCanonicalProfileId` constructor option to `RemoteFeatureFlagController` for threshold flag segmentation ([#9325](MetaMask/core#9325)) - Add optional `instanceOptions.remoteFeatureFlagController.metaMetricsFlags` constructor option to `RemoteFeatureFlagController` to segment flags by MetaMetrics ID ([#9325](MetaMask/core#9325)) - **BREAKING:** Wire `ConfigRegistryApiService` and `ConfigRegistryController` into the default wallet initialization ([#9928](MetaMask/core#9928)) - Adds a required `configRegistryApiService` slot to `instanceOptions` with a required `env` (`ConfigRegistryApiEnv`) and optional `fetch` and `policyOptions`. `fetch` defaults to `globalThis.fetch` via `ConfigRegistryApiService`. - Adds an optional `configRegistryController` slot to `instanceOptions` for optional `pollingInterval` and `fallbackConfig`. - `ConfigRegistryController` delegates `KeyringController:getState`, `RemoteFeatureFlagController:getState`, and `ConfigRegistryApiService:fetchConfig`, and subscribes to `KeyringController:unlock`, `KeyringController:lock`, and `RemoteFeatureFlagController:stateChange`. - Consumers that pass their own root messenger and already wire `ConfigRegistryApiService` / `ConfigRegistryController` must remove their own before upgrading, or the duplicate registration will collide. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/WPN-1879 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches remote feature flag segmentation, persisted state migration, and moves config registry initialization into wallet—behavior changes at sign-in and upgrade paths warrant careful QA. > > **Overview** > Upgrades **`@metamask/wallet`** to **^12.0.3** with **`@metamask/config-registry-controller` ^3** and **`@metamask/remote-feature-flag-controller` ^6.1.1**, and removes the extension’s duplicate **Config Registry** messenger-client init so **`ConfigRegistryController`** / **`ConfigRegistryApiService`** are owned by the wallet (including new **`getConfigRegistryApiServiceInstanceOptions`** with PRD vs UAT env from build type). > > **Remote feature flags** are updated for RFFC 6: **`getCanonicalProfileId`** (from **`AuthenticationController`**, MetaMetrics fallback), safer early-init ID resolution, and **`setupRemoteFeatureFlagToggle`** now listens for auth state changes and **force-refreshes** flags when the canonical profile id appears or changes. Migration **224.1** strips persisted **`rawRemoteFeatureFlags`** so old redacted cache is not reused. > > E2E fixtures/mocks and LavaMoat policies are adjusted for threshold-flag shape and wallet-owned packages. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 967b8ce. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
runway-github Bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 9, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/wallet` to `^12.0.0` ```markdown ## [12.0.0] ### Added - Add optional `instanceOptions.remoteFeatureFlagController.getCanonicalProfileId` constructor option to `RemoteFeatureFlagController` for threshold flag segmentation ([#9325](MetaMask/core#9325)) - Add optional `instanceOptions.remoteFeatureFlagController.metaMetricsFlags` constructor option to `RemoteFeatureFlagController` to segment flags by MetaMetrics ID ([#9325](MetaMask/core#9325)) - **BREAKING:** Wire `ConfigRegistryApiService` and `ConfigRegistryController` into the default wallet initialization ([#9928](MetaMask/core#9928)) - Adds a required `configRegistryApiService` slot to `instanceOptions` with a required `env` (`ConfigRegistryApiEnv`) and optional `fetch` and `policyOptions`. `fetch` defaults to `globalThis.fetch` via `ConfigRegistryApiService`. - Adds an optional `configRegistryController` slot to `instanceOptions` for optional `pollingInterval` and `fallbackConfig`. - `ConfigRegistryController` delegates `KeyringController:getState`, `RemoteFeatureFlagController:getState`, and `ConfigRegistryApiService:fetchConfig`, and subscribes to `KeyringController:unlock`, `KeyringController:lock`, and `RemoteFeatureFlagController:stateChange`. - Consumers that pass their own root messenger and already wire `ConfigRegistryApiService` / `ConfigRegistryController` must remove their own before upgrading, or the duplicate registration will collide. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/WPN-1879 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches remote feature flag segmentation, persisted state migration, and moves config registry initialization into wallet—behavior changes at sign-in and upgrade paths warrant careful QA. > > **Overview** > Upgrades **`@metamask/wallet`** to **^12.0.3** with **`@metamask/config-registry-controller` ^3** and **`@metamask/remote-feature-flag-controller` ^6.1.1**, and removes the extension’s duplicate **Config Registry** messenger-client init so **`ConfigRegistryController`** / **`ConfigRegistryApiService`** are owned by the wallet (including new **`getConfigRegistryApiServiceInstanceOptions`** with PRD vs UAT env from build type). > > **Remote feature flags** are updated for RFFC 6: **`getCanonicalProfileId`** (from **`AuthenticationController`**, MetaMetrics fallback), safer early-init ID resolution, and **`setupRemoteFeatureFlagToggle`** now listens for auth state changes and **force-refreshes** flags when the canonical profile id appears or changes. Migration **224.1** strips persisted **`rawRemoteFeatureFlags`** so old redacted cache is not reused. > > E2E fixtures/mocks and LavaMoat policies are adjusted for threshold-flag shape and wallet-owned packages. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 967b8ce. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
pull Bot
pushed a commit
to Reality2byte/metamask-extension
that referenced
this pull request
Sep 9, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/wallet` to `^12.0.0` ```markdown ## [12.0.0] ### Added - Add optional `instanceOptions.remoteFeatureFlagController.getCanonicalProfileId` constructor option to `RemoteFeatureFlagController` for threshold flag segmentation ([MetaMask#9325](MetaMask/core#9325)) - Add optional `instanceOptions.remoteFeatureFlagController.metaMetricsFlags` constructor option to `RemoteFeatureFlagController` to segment flags by MetaMetrics ID ([MetaMask#9325](MetaMask/core#9325)) - **BREAKING:** Wire `ConfigRegistryApiService` and `ConfigRegistryController` into the default wallet initialization ([MetaMask#9928](MetaMask/core#9928)) - Adds a required `configRegistryApiService` slot to `instanceOptions` with a required `env` (`ConfigRegistryApiEnv`) and optional `fetch` and `policyOptions`. `fetch` defaults to `globalThis.fetch` via `ConfigRegistryApiService`. - Adds an optional `configRegistryController` slot to `instanceOptions` for optional `pollingInterval` and `fallbackConfig`. - `ConfigRegistryController` delegates `KeyringController:getState`, `RemoteFeatureFlagController:getState`, and `ConfigRegistryApiService:fetchConfig`, and subscribes to `KeyringController:unlock`, `KeyringController:lock`, and `RemoteFeatureFlagController:stateChange`. - Consumers that pass their own root messenger and already wire `ConfigRegistryApiService` / `ConfigRegistryController` must remove their own before upgrading, or the duplicate registration will collide. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/WPN-1879 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches remote feature flag segmentation, persisted state migration, and moves config registry initialization into wallet—behavior changes at sign-in and upgrade paths warrant careful QA. > > **Overview** > Upgrades **`@metamask/wallet`** to **^12.0.3** with **`@metamask/config-registry-controller` ^3** and **`@metamask/remote-feature-flag-controller` ^6.1.1**, and removes the extension’s duplicate **Config Registry** messenger-client init so **`ConfigRegistryController`** / **`ConfigRegistryApiService`** are owned by the wallet (including new **`getConfigRegistryApiServiceInstanceOptions`** with PRD vs UAT env from build type). > > **Remote feature flags** are updated for RFFC 6: **`getCanonicalProfileId`** (from **`AuthenticationController`**, MetaMetrics fallback), safer early-init ID resolution, and **`setupRemoteFeatureFlagToggle`** now listens for auth state changes and **force-refreshes** flags when the canonical profile id appears or changes. Migration **224.1** strips persisted **`rawRemoteFeatureFlags`** so old redacted cache is not reused. > > E2E fixtures/mocks and LavaMoat policies are adjusted for threshold-flag shape and wallet-owned packages. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 967b8ce. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
runway-github Bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 9, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/wallet` to `^12.0.0` ```markdown ## [12.0.0] ### Added - Add optional `instanceOptions.remoteFeatureFlagController.getCanonicalProfileId` constructor option to `RemoteFeatureFlagController` for threshold flag segmentation ([#9325](MetaMask/core#9325)) - Add optional `instanceOptions.remoteFeatureFlagController.metaMetricsFlags` constructor option to `RemoteFeatureFlagController` to segment flags by MetaMetrics ID ([#9325](MetaMask/core#9325)) - **BREAKING:** Wire `ConfigRegistryApiService` and `ConfigRegistryController` into the default wallet initialization ([#9928](MetaMask/core#9928)) - Adds a required `configRegistryApiService` slot to `instanceOptions` with a required `env` (`ConfigRegistryApiEnv`) and optional `fetch` and `policyOptions`. `fetch` defaults to `globalThis.fetch` via `ConfigRegistryApiService`. - Adds an optional `configRegistryController` slot to `instanceOptions` for optional `pollingInterval` and `fallbackConfig`. - `ConfigRegistryController` delegates `KeyringController:getState`, `RemoteFeatureFlagController:getState`, and `ConfigRegistryApiService:fetchConfig`, and subscribes to `KeyringController:unlock`, `KeyringController:lock`, and `RemoteFeatureFlagController:stateChange`. - Consumers that pass their own root messenger and already wire `ConfigRegistryApiService` / `ConfigRegistryController` must remove their own before upgrading, or the duplicate registration will collide. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/WPN-1879 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches remote feature flag segmentation, persisted state migration, and moves config registry initialization into wallet—behavior changes at sign-in and upgrade paths warrant careful QA. > > **Overview** > Upgrades **`@metamask/wallet`** to **^12.0.3** with **`@metamask/config-registry-controller` ^3** and **`@metamask/remote-feature-flag-controller` ^6.1.1**, and removes the extension’s duplicate **Config Registry** messenger-client init so **`ConfigRegistryController`** / **`ConfigRegistryApiService`** are owned by the wallet (including new **`getConfigRegistryApiServiceInstanceOptions`** with PRD vs UAT env from build type). > > **Remote feature flags** are updated for RFFC 6: **`getCanonicalProfileId`** (from **`AuthenticationController`**, MetaMetrics fallback), safer early-init ID resolution, and **`setupRemoteFeatureFlagToggle`** now listens for auth state changes and **force-refreshes** flags when the canonical profile id appears or changes. Migration **224.1** strips persisted **`rawRemoteFeatureFlags`** so old redacted cache is not reused. > > E2E fixtures/mocks and LavaMoat policies are adjusted for threshold-flag shape and wallet-owned packages. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 967b8ce. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
runway-github Bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 9, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/wallet` to `^12.0.0` ```markdown ## [12.0.0] ### Added - Add optional `instanceOptions.remoteFeatureFlagController.getCanonicalProfileId` constructor option to `RemoteFeatureFlagController` for threshold flag segmentation ([#9325](MetaMask/core#9325)) - Add optional `instanceOptions.remoteFeatureFlagController.metaMetricsFlags` constructor option to `RemoteFeatureFlagController` to segment flags by MetaMetrics ID ([#9325](MetaMask/core#9325)) - **BREAKING:** Wire `ConfigRegistryApiService` and `ConfigRegistryController` into the default wallet initialization ([#9928](MetaMask/core#9928)) - Adds a required `configRegistryApiService` slot to `instanceOptions` with a required `env` (`ConfigRegistryApiEnv`) and optional `fetch` and `policyOptions`. `fetch` defaults to `globalThis.fetch` via `ConfigRegistryApiService`. - Adds an optional `configRegistryController` slot to `instanceOptions` for optional `pollingInterval` and `fallbackConfig`. - `ConfigRegistryController` delegates `KeyringController:getState`, `RemoteFeatureFlagController:getState`, and `ConfigRegistryApiService:fetchConfig`, and subscribes to `KeyringController:unlock`, `KeyringController:lock`, and `RemoteFeatureFlagController:stateChange`. - Consumers that pass their own root messenger and already wire `ConfigRegistryApiService` / `ConfigRegistryController` must remove their own before upgrading, or the duplicate registration will collide. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/WPN-1879 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches remote feature flag segmentation, persisted state migration, and moves config registry initialization into wallet—behavior changes at sign-in and upgrade paths warrant careful QA. > > **Overview** > Upgrades **`@metamask/wallet`** to **^12.0.3** with **`@metamask/config-registry-controller` ^3** and **`@metamask/remote-feature-flag-controller` ^6.1.1**, and removes the extension’s duplicate **Config Registry** messenger-client init so **`ConfigRegistryController`** / **`ConfigRegistryApiService`** are owned by the wallet (including new **`getConfigRegistryApiServiceInstanceOptions`** with PRD vs UAT env from build type). > > **Remote feature flags** are updated for RFFC 6: **`getCanonicalProfileId`** (from **`AuthenticationController`**, MetaMetrics fallback), safer early-init ID resolution, and **`setupRemoteFeatureFlagToggle`** now listens for auth state changes and **force-refreshes** flags when the canonical profile id appears or changes. Migration **224.1** strips persisted **`rawRemoteFeatureFlags`** so old redacted cache is not reused. > > E2E fixtures/mocks and LavaMoat policies are adjusted for threshold-flag shape and wallet-owned packages. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 967b8ce. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
runway-github Bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 9, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/wallet` to `^12.0.0` ```markdown ## [12.0.0] ### Added - Add optional `instanceOptions.remoteFeatureFlagController.getCanonicalProfileId` constructor option to `RemoteFeatureFlagController` for threshold flag segmentation ([#9325](MetaMask/core#9325)) - Add optional `instanceOptions.remoteFeatureFlagController.metaMetricsFlags` constructor option to `RemoteFeatureFlagController` to segment flags by MetaMetrics ID ([#9325](MetaMask/core#9325)) - **BREAKING:** Wire `ConfigRegistryApiService` and `ConfigRegistryController` into the default wallet initialization ([#9928](MetaMask/core#9928)) - Adds a required `configRegistryApiService` slot to `instanceOptions` with a required `env` (`ConfigRegistryApiEnv`) and optional `fetch` and `policyOptions`. `fetch` defaults to `globalThis.fetch` via `ConfigRegistryApiService`. - Adds an optional `configRegistryController` slot to `instanceOptions` for optional `pollingInterval` and `fallbackConfig`. - `ConfigRegistryController` delegates `KeyringController:getState`, `RemoteFeatureFlagController:getState`, and `ConfigRegistryApiService:fetchConfig`, and subscribes to `KeyringController:unlock`, `KeyringController:lock`, and `RemoteFeatureFlagController:stateChange`. - Consumers that pass their own root messenger and already wire `ConfigRegistryApiService` / `ConfigRegistryController` must remove their own before upgrading, or the duplicate registration will collide. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/WPN-1879 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches remote feature flag segmentation, persisted state migration, and moves config registry initialization into wallet—behavior changes at sign-in and upgrade paths warrant careful QA. > > **Overview** > Upgrades **`@metamask/wallet`** to **^12.0.3** with **`@metamask/config-registry-controller` ^3** and **`@metamask/remote-feature-flag-controller` ^6.1.1**, and removes the extension’s duplicate **Config Registry** messenger-client init so **`ConfigRegistryController`** / **`ConfigRegistryApiService`** are owned by the wallet (including new **`getConfigRegistryApiServiceInstanceOptions`** with PRD vs UAT env from build type). > > **Remote feature flags** are updated for RFFC 6: **`getCanonicalProfileId`** (from **`AuthenticationController`**, MetaMetrics fallback), safer early-init ID resolution, and **`setupRemoteFeatureFlagToggle`** now listens for auth state changes and **force-refreshes** flags when the canonical profile id appears or changes. Migration **224.1** strips persisted **`rawRemoteFeatureFlags`** so old redacted cache is not reused. > > E2E fixtures/mocks and LavaMoat policies are adjusted for threshold-flag shape and wallet-owned packages. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 967b8ce. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
runway-github Bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 9, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/wallet` to `^12.0.0` ```markdown ## [12.0.0] ### Added - Add optional `instanceOptions.remoteFeatureFlagController.getCanonicalProfileId` constructor option to `RemoteFeatureFlagController` for threshold flag segmentation ([#9325](MetaMask/core#9325)) - Add optional `instanceOptions.remoteFeatureFlagController.metaMetricsFlags` constructor option to `RemoteFeatureFlagController` to segment flags by MetaMetrics ID ([#9325](MetaMask/core#9325)) - **BREAKING:** Wire `ConfigRegistryApiService` and `ConfigRegistryController` into the default wallet initialization ([#9928](MetaMask/core#9928)) - Adds a required `configRegistryApiService` slot to `instanceOptions` with a required `env` (`ConfigRegistryApiEnv`) and optional `fetch` and `policyOptions`. `fetch` defaults to `globalThis.fetch` via `ConfigRegistryApiService`. - Adds an optional `configRegistryController` slot to `instanceOptions` for optional `pollingInterval` and `fallbackConfig`. - `ConfigRegistryController` delegates `KeyringController:getState`, `RemoteFeatureFlagController:getState`, and `ConfigRegistryApiService:fetchConfig`, and subscribes to `KeyringController:unlock`, `KeyringController:lock`, and `RemoteFeatureFlagController:stateChange`. - Consumers that pass their own root messenger and already wire `ConfigRegistryApiService` / `ConfigRegistryController` must remove their own before upgrading, or the duplicate registration will collide. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/WPN-1879 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches remote feature flag segmentation, persisted state migration, and moves config registry initialization into wallet—behavior changes at sign-in and upgrade paths warrant careful QA. > > **Overview** > Upgrades **`@metamask/wallet`** to **^12.0.3** with **`@metamask/config-registry-controller` ^3** and **`@metamask/remote-feature-flag-controller` ^6.1.1**, and removes the extension’s duplicate **Config Registry** messenger-client init so **`ConfigRegistryController`** / **`ConfigRegistryApiService`** are owned by the wallet (including new **`getConfigRegistryApiServiceInstanceOptions`** with PRD vs UAT env from build type). > > **Remote feature flags** are updated for RFFC 6: **`getCanonicalProfileId`** (from **`AuthenticationController`**, MetaMetrics fallback), safer early-init ID resolution, and **`setupRemoteFeatureFlagToggle`** now listens for auth state changes and **force-refreshes** flags when the canonical profile id appears or changes. Migration **224.1** strips persisted **`rawRemoteFeatureFlags`** so old redacted cache is not reused. > > E2E fixtures/mocks and LavaMoat policies are adjusted for threshold-flag shape and wallet-owned packages. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 967b8ce. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
runway-github Bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 9, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/wallet` to `^12.0.0` ```markdown ## [12.0.0] ### Added - Add optional `instanceOptions.remoteFeatureFlagController.getCanonicalProfileId` constructor option to `RemoteFeatureFlagController` for threshold flag segmentation ([#9325](MetaMask/core#9325)) - Add optional `instanceOptions.remoteFeatureFlagController.metaMetricsFlags` constructor option to `RemoteFeatureFlagController` to segment flags by MetaMetrics ID ([#9325](MetaMask/core#9325)) - **BREAKING:** Wire `ConfigRegistryApiService` and `ConfigRegistryController` into the default wallet initialization ([#9928](MetaMask/core#9928)) - Adds a required `configRegistryApiService` slot to `instanceOptions` with a required `env` (`ConfigRegistryApiEnv`) and optional `fetch` and `policyOptions`. `fetch` defaults to `globalThis.fetch` via `ConfigRegistryApiService`. - Adds an optional `configRegistryController` slot to `instanceOptions` for optional `pollingInterval` and `fallbackConfig`. - `ConfigRegistryController` delegates `KeyringController:getState`, `RemoteFeatureFlagController:getState`, and `ConfigRegistryApiService:fetchConfig`, and subscribes to `KeyringController:unlock`, `KeyringController:lock`, and `RemoteFeatureFlagController:stateChange`. - Consumers that pass their own root messenger and already wire `ConfigRegistryApiService` / `ConfigRegistryController` must remove their own before upgrading, or the duplicate registration will collide. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/WPN-1879 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches remote feature flag segmentation, persisted state migration, and moves config registry initialization into wallet—behavior changes at sign-in and upgrade paths warrant careful QA. > > **Overview** > Upgrades **`@metamask/wallet`** to **^12.0.3** with **`@metamask/config-registry-controller` ^3** and **`@metamask/remote-feature-flag-controller` ^6.1.1**, and removes the extension’s duplicate **Config Registry** messenger-client init so **`ConfigRegistryController`** / **`ConfigRegistryApiService`** are owned by the wallet (including new **`getConfigRegistryApiServiceInstanceOptions`** with PRD vs UAT env from build type). > > **Remote feature flags** are updated for RFFC 6: **`getCanonicalProfileId`** (from **`AuthenticationController`**, MetaMetrics fallback), safer early-init ID resolution, and **`setupRemoteFeatureFlagToggle`** now listens for auth state changes and **force-refreshes** flags when the canonical profile id appears or changes. Migration **224.1** strips persisted **`rawRemoteFeatureFlags`** so old redacted cache is not reused. > > E2E fixtures/mocks and LavaMoat policies are adjusted for threshold-flag shape and wallet-owned packages. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 967b8ce. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
runway-github Bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 9, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/wallet` to `^12.0.0` ```markdown ## [12.0.0] ### Added - Add optional `instanceOptions.remoteFeatureFlagController.getCanonicalProfileId` constructor option to `RemoteFeatureFlagController` for threshold flag segmentation ([#9325](MetaMask/core#9325)) - Add optional `instanceOptions.remoteFeatureFlagController.metaMetricsFlags` constructor option to `RemoteFeatureFlagController` to segment flags by MetaMetrics ID ([#9325](MetaMask/core#9325)) - **BREAKING:** Wire `ConfigRegistryApiService` and `ConfigRegistryController` into the default wallet initialization ([#9928](MetaMask/core#9928)) - Adds a required `configRegistryApiService` slot to `instanceOptions` with a required `env` (`ConfigRegistryApiEnv`) and optional `fetch` and `policyOptions`. `fetch` defaults to `globalThis.fetch` via `ConfigRegistryApiService`. - Adds an optional `configRegistryController` slot to `instanceOptions` for optional `pollingInterval` and `fallbackConfig`. - `ConfigRegistryController` delegates `KeyringController:getState`, `RemoteFeatureFlagController:getState`, and `ConfigRegistryApiService:fetchConfig`, and subscribes to `KeyringController:unlock`, `KeyringController:lock`, and `RemoteFeatureFlagController:stateChange`. - Consumers that pass their own root messenger and already wire `ConfigRegistryApiService` / `ConfigRegistryController` must remove their own before upgrading, or the duplicate registration will collide. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/WPN-1879 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches remote feature flag segmentation, persisted state migration, and moves config registry initialization into wallet—behavior changes at sign-in and upgrade paths warrant careful QA. > > **Overview** > Upgrades **`@metamask/wallet`** to **^12.0.3** with **`@metamask/config-registry-controller` ^3** and **`@metamask/remote-feature-flag-controller` ^6.1.1**, and removes the extension’s duplicate **Config Registry** messenger-client init so **`ConfigRegistryController`** / **`ConfigRegistryApiService`** are owned by the wallet (including new **`getConfigRegistryApiServiceInstanceOptions`** with PRD vs UAT env from build type). > > **Remote feature flags** are updated for RFFC 6: **`getCanonicalProfileId`** (from **`AuthenticationController`**, MetaMetrics fallback), safer early-init ID resolution, and **`setupRemoteFeatureFlagToggle`** now listens for auth state changes and **force-refreshes** flags when the canonical profile id appears or changes. Migration **224.1** strips persisted **`rawRemoteFeatureFlags`** so old redacted cache is not reused. > > E2E fixtures/mocks and LavaMoat policies are adjusted for threshold-flag shape and wallet-owned packages. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 967b8ce. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
runway-github Bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 9, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/wallet` to `^12.0.0` ```markdown ## [12.0.0] ### Added - Add optional `instanceOptions.remoteFeatureFlagController.getCanonicalProfileId` constructor option to `RemoteFeatureFlagController` for threshold flag segmentation ([#9325](MetaMask/core#9325)) - Add optional `instanceOptions.remoteFeatureFlagController.metaMetricsFlags` constructor option to `RemoteFeatureFlagController` to segment flags by MetaMetrics ID ([#9325](MetaMask/core#9325)) - **BREAKING:** Wire `ConfigRegistryApiService` and `ConfigRegistryController` into the default wallet initialization ([#9928](MetaMask/core#9928)) - Adds a required `configRegistryApiService` slot to `instanceOptions` with a required `env` (`ConfigRegistryApiEnv`) and optional `fetch` and `policyOptions`. `fetch` defaults to `globalThis.fetch` via `ConfigRegistryApiService`. - Adds an optional `configRegistryController` slot to `instanceOptions` for optional `pollingInterval` and `fallbackConfig`. - `ConfigRegistryController` delegates `KeyringController:getState`, `RemoteFeatureFlagController:getState`, and `ConfigRegistryApiService:fetchConfig`, and subscribes to `KeyringController:unlock`, `KeyringController:lock`, and `RemoteFeatureFlagController:stateChange`. - Consumers that pass their own root messenger and already wire `ConfigRegistryApiService` / `ConfigRegistryController` must remove their own before upgrading, or the duplicate registration will collide. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/WPN-1879 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches remote feature flag segmentation, persisted state migration, and moves config registry initialization into wallet—behavior changes at sign-in and upgrade paths warrant careful QA. > > **Overview** > Upgrades **`@metamask/wallet`** to **^12.0.3** with **`@metamask/config-registry-controller` ^3** and **`@metamask/remote-feature-flag-controller` ^6.1.1**, and removes the extension’s duplicate **Config Registry** messenger-client init so **`ConfigRegistryController`** / **`ConfigRegistryApiService`** are owned by the wallet (including new **`getConfigRegistryApiServiceInstanceOptions`** with PRD vs UAT env from build type). > > **Remote feature flags** are updated for RFFC 6: **`getCanonicalProfileId`** (from **`AuthenticationController`**, MetaMetrics fallback), safer early-init ID resolution, and **`setupRemoteFeatureFlagToggle`** now listens for auth state changes and **force-refreshes** flags when the canonical profile id appears or changes. Migration **224.1** strips persisted **`rawRemoteFeatureFlags`** so old redacted cache is not reused. > > E2E fixtures/mocks and LavaMoat policies are adjusted for threshold-flag shape and wallet-owned packages. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 967b8ce. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
runway-github Bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 9, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/wallet` to `^12.0.0` ```markdown ## [12.0.0] ### Added - Add optional `instanceOptions.remoteFeatureFlagController.getCanonicalProfileId` constructor option to `RemoteFeatureFlagController` for threshold flag segmentation ([#9325](MetaMask/core#9325)) - Add optional `instanceOptions.remoteFeatureFlagController.metaMetricsFlags` constructor option to `RemoteFeatureFlagController` to segment flags by MetaMetrics ID ([#9325](MetaMask/core#9325)) - **BREAKING:** Wire `ConfigRegistryApiService` and `ConfigRegistryController` into the default wallet initialization ([#9928](MetaMask/core#9928)) - Adds a required `configRegistryApiService` slot to `instanceOptions` with a required `env` (`ConfigRegistryApiEnv`) and optional `fetch` and `policyOptions`. `fetch` defaults to `globalThis.fetch` via `ConfigRegistryApiService`. - Adds an optional `configRegistryController` slot to `instanceOptions` for optional `pollingInterval` and `fallbackConfig`. - `ConfigRegistryController` delegates `KeyringController:getState`, `RemoteFeatureFlagController:getState`, and `ConfigRegistryApiService:fetchConfig`, and subscribes to `KeyringController:unlock`, `KeyringController:lock`, and `RemoteFeatureFlagController:stateChange`. - Consumers that pass their own root messenger and already wire `ConfigRegistryApiService` / `ConfigRegistryController` must remove their own before upgrading, or the duplicate registration will collide. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/WPN-1879 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches remote feature flag segmentation, persisted state migration, and moves config registry initialization into wallet—behavior changes at sign-in and upgrade paths warrant careful QA. > > **Overview** > Upgrades **`@metamask/wallet`** to **^12.0.3** with **`@metamask/config-registry-controller` ^3** and **`@metamask/remote-feature-flag-controller` ^6.1.1**, and removes the extension’s duplicate **Config Registry** messenger-client init so **`ConfigRegistryController`** / **`ConfigRegistryApiService`** are owned by the wallet (including new **`getConfigRegistryApiServiceInstanceOptions`** with PRD vs UAT env from build type). > > **Remote feature flags** are updated for RFFC 6: **`getCanonicalProfileId`** (from **`AuthenticationController`**, MetaMetrics fallback), safer early-init ID resolution, and **`setupRemoteFeatureFlagToggle`** now listens for auth state changes and **force-refreshes** flags when the canonical profile id appears or changes. Migration **224.1** strips persisted **`rawRemoteFeatureFlags`** so old redacted cache is not reused. > > E2E fixtures/mocks and LavaMoat policies are adjusted for threshold-flag shape and wallet-owned packages. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 967b8ce. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
vpintorico
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 9, 2026
….3` (#46177) - chore: bump `@metamask/wallet` to `^12.0.3` cp-13.48.0 (#45749) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/wallet` to `^12.0.0` ```markdown ## [12.0.0] ### Added - Add optional `instanceOptions.remoteFeatureFlagController.getCanonicalProfileId` constructor option to `RemoteFeatureFlagController` for threshold flag segmentation ([#9325](MetaMask/core#9325)) - Add optional `instanceOptions.remoteFeatureFlagController.metaMetricsFlags` constructor option to `RemoteFeatureFlagController` to segment flags by MetaMetrics ID ([#9325](MetaMask/core#9325)) - **BREAKING:** Wire `ConfigRegistryApiService` and `ConfigRegistryController` into the default wallet initialization ([#9928](MetaMask/core#9928)) - Adds a required `configRegistryApiService` slot to `instanceOptions` with a required `env` (`ConfigRegistryApiEnv`) and optional `fetch` and `policyOptions`. `fetch` defaults to `globalThis.fetch` via `ConfigRegistryApiService`. - Adds an optional `configRegistryController` slot to `instanceOptions` for optional `pollingInterval` and `fallbackConfig`. - `ConfigRegistryController` delegates `KeyringController:getState`, `RemoteFeatureFlagController:getState`, and `ConfigRegistryApiService:fetchConfig`, and subscribes to `KeyringController:unlock`, `KeyringController:lock`, and `RemoteFeatureFlagController:stateChange`. - Consumers that pass their own root messenger and already wire `ConfigRegistryApiService` / `ConfigRegistryController` must remove their own before upgrading, or the duplicate registration will collide. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Related to: https://consensyssoftware.atlassian.net/browse/WPN-1879 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches remote feature flag segmentation, persisted state migration, and moves config registry initialization into wallet—behavior changes at sign-in and upgrade paths warrant careful QA. > > **Overview** > Upgrades **`@metamask/wallet`** to **^12.0.3** with **`@metamask/config-registry-controller` ^3** and **`@metamask/remote-feature-flag-controller` ^6.1.1**, and removes the extension’s duplicate **Config Registry** messenger-client init so **`ConfigRegistryController`** / **`ConfigRegistryApiService`** are owned by the wallet (including new **`getConfigRegistryApiServiceInstanceOptions`** with PRD vs UAT env from build type). > > **Remote feature flags** are updated for RFFC 6: **`getCanonicalProfileId`** (from **`AuthenticationController`**, MetaMetrics fallback), safer early-init ID resolution, and **`setupRemoteFeatureFlagToggle`** now listens for auth state changes and **force-refreshes** flags when the canonical profile id appears or changes. Migration **224.1** strips persisted **`rawRemoteFeatureFlags`** so old redacted cache is not reused. > > E2E fixtures/mocks and LavaMoat policies are adjusted for threshold-flag shape and wallet-owned packages. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 967b8ce. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> [1fc81a2](1fc81a2) --------- Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com> Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: mikesposito <michele@esposito.codes>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCanonicalProfileIdconstructor callback andmetaMetricsFlagsmap for threshold flag segmentation.metaMetricsFlagsuse MetaMetrics ID instead.@metamask/walletremote feature flag controller initialization.Segmentation Behavior
metaMetricsFlagsgetCanonicalProfileId()metaMetricsFlagsgetMetaMetricsId()If the selected identifier is empty, threshold arrays are preserved as-is and not processed.
Example threshold config using canonical segmentation by default:
{ "myCanonicalFlag": [ { "name": "groupA", "scope": { "type": "threshold", "value": 0.5 }, "value": "valueA" }, { "name": "groupB", "scope": { "type": "threshold", "value": 1.0 }, "value": "valueB" } ] }Example controller setup for a flag that should keep MetaMetrics segmentation:
Migration
Consumers must pass
getCanonicalProfileIdfor threshold flags that should use canonical profile segmentation, which is now the default for flags absent frommetaMetricsFlags.Existing threshold flags that must keep MetaMetrics-based bucketing should be listed in
metaMetricsFlagsand continue to providegetMetaMetricsId.Test plan
yarn workspace @metamask/remote-feature-flag-controller run jest --no-coverage src/utils/user-segmentation-utils.test.ts src/remote-feature-flag-controller.test.tsmetaMetricsFlagsusegetCanonicalProfileIdfor segmentationmetaMetricsFlagsusegetMetaMetricsIdfor segmentationRelated
Note
Medium Risk
Breaking constructor and experiment-assignment change: existing threshold flags will re-bucket unless listed in
metaMetricsFlags. Not auth or payment logic, but it can change live A/B group membership.Overview
Breaking: threshold flags now bucket by canonical profile ID by default instead of MetaMetrics ID.
RemoteFeatureFlagControllerrequiresgetCanonicalProfileId; flags listed in optionalmetaMetricsFlagsstill usegetMetaMetricsId.Hash-based assignment hashes the chosen segmentation ID. If that ID is empty, the threshold array is left unprocessed. Explicit MetaMetrics ID targeting is unchanged. Threshold cache keys and stale-entry cleanup cover both identifiers.
@metamask/walletforwards the new options (optional; empty-string default for canonical ID). Consumers that need the old MetaMetrics bucketing must list those flag names inmetaMetricsFlags.Reviewed by Cursor Bugbot for commit 09b141f. Bugbot is set up for automated code reviews on this repo. Configure here.